-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new edtion and product id for Open Liberty #3258
Conversation
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vYd3kEezEeiBcaHL18STjw Target locations of links might be accessible only to IBM employees. |
dfe3351
to
d1c4c46
Compare
first build failed as the tests hadn't been updated properly |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5RSZMEfnEeiBcaHL18STjw Target locations of links might be accessible only to IBM employees. |
The build idlewis-3258-20180424-1856 |
AppliesToProcessor needs to recognize OPEN as a valid edition and also have an appropriate mapping to a human readable edition. OPEN features can be installed on any edition apart from CORE Also do a bit of refactoring to put the parsing logic into a common method, and make a couple of methods private, as they clearly should have been
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_4zOckEiJEeiBcaHL18STjw Target locations of links might be accessible only to IBM employees. |
EARLY_ACCESS("EARLY_ACCESS"); | ||
EARLY_ACCESS("EARLY_ACCESS"), | ||
Open("Open"), | ||
Open_Web("Open_Web"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going from upper case to camel case (ish) is the only change here from the previous attempt at this pull request
The build idlewis-3258-20180425-1417 |
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jMayIEkLEeiBcaHL18STjw Target locations of links might be accessible only to IBM employees. |
idlewis-3258-20180425-1417 build passed all tests, but there were javacores in the BVT, can't work out why, and there shouldn't be anything in this pull request which should cause it. |
The build idlewis-3258-20180426-0546 |
This is a re-do of pull request #3215, but with the product id correctly capitalized as per conversation in #3246